Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyperv detection: increase timeout from 2s to 8s #6701

Merged
merged 2 commits into from
Feb 26, 2020
Merged

hyperv detection: increase timeout from 2s to 8s #6701

merged 2 commits into from
Feb 26, 2020

Conversation

sshukun
Copy link
Contributor

@sshukun sshukun commented Feb 20, 2020

fixes #6579
Also try to add different error and suggestion message when the command timed out.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sshukun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sshukun
To complete the pull request process, please assign josedonizetti
You can assign the PR to them by writing /assign @josedonizetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@priyawadhwa
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 94.135255 90.874281 94.638827]
All Times Minikube (PR 6701): [ 92.119826 92.775237 90.368617]

Average minikube: 93.216121
Average Minikube (PR 6701): 91.754560

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6701) |
+----------------------+-----------+--------------------+
| minikube v           |  0.133581 |           0.123762 |
| Creating kvm2        | 19.720811 |          20.361991 |
| Preparing Kubernetes | 51.653579 |          49.645316 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.938824 |          19.862472 |
| Waiting for cluster  |  0.097397 |           0.235441 |
+----------------------+-----------+--------------------+

@tstromberg
Copy link
Contributor

Thank you!

@tstromberg tstromberg changed the title Increase detection timeout from 2s to 4s for hyperV hyperv detection: increase timeout from 2s to 8s Feb 20, 2020
@minikube-pr-bot
Copy link

All Times minikube: [ 93.779494 93.332565 95.652047]
All Times Minikube (PR 6701): [ 93.233824 93.867830 90.716138]

Average minikube: 94.254702
Average Minikube (PR 6701): 92.605931

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6701) |
+----------------------+-----------+--------------------+
| minikube v           |  0.129974 |           0.126000 |
| Creating kvm2        | 20.211343 |          19.671326 |
| Preparing Kubernetes | 51.448097 |          50.404930 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.757228 |          20.175126 |
| Waiting for cluster  |  0.070462 |           0.227926 |
+----------------------+-----------+--------------------+

@priyawadhwa
Copy link

This looks good to me -- thanks for adding this change!

@priyawadhwa priyawadhwa merged commit f77e942 into kubernetes:master Feb 26, 2020
@priyawadhwa priyawadhwa mentioned this pull request Feb 26, 2020
Closed
@sshukun sshukun deleted the increase-timeout branch February 27, 2020 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase vm-driver detection timeout from 2s to 4s for hyperV
6 participants
@sshukun @k8s-ci-robot @minikube-bot @priyawadhwa @minikube-pr-bot @tstromberg